Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Modify path of backups #2973

Closed
KellicTiger opened this issue May 13, 2024 · 8 comments
Closed

[Enhancement]: Modify path of backups #2973

KellicTiger opened this issue May 13, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@KellicTiger
Copy link

Type of Enhancement

Web Interface/Frontend

Describe the Feature/Enhancement

The target for where the backups are located is on the same volume where the application is installed

image

Best practice for backups is to put them on a volume other than where you are running the application or where the dataset is located. While it is possible for me to symlink a location to where my backup drive it, the better option is to allow the path to be modified.

As a temp work around document where the pathing is stored. I'm assuming it is in a config file somewhere.

Why would this be helpful?

Adhering to best practices for backups. As in the event of the drive where the app is stored you would also lose the backup.

Allowing the changing of the path to another drive would allow for better data protection.

Future Implementation (Screenshot)

image

Audiobookshelf Server Version

v2.9.0

Current Implementation (Screenshot)

No response

@KellicTiger KellicTiger added the enhancement New feature or request label May 13, 2024
@nichwall
Copy link
Contributor

nichwall commented May 14, 2024

Duplicate of #199 but this uses the new issue format and looks nicer :)

@noja11
Copy link

noja11 commented May 14, 2024

Amazing that I'm just finding this right now and the request is so new!

I'm currently moving ABS from Docker to an LXC and I'm having a hard time linking it to my standard services backup share. Either changing it from within the app or allowing it to be set in the config file at /etc/default/audiobookshelf would be amazing. Thank you all for your effort!

@ZLoth
Copy link

ZLoth commented May 18, 2024

As I'm running ABS as a Docker container on TrueNAS Scale. I just set up a mapping from /metadata/backups to my backups folder. That folder is then uploaded nightly to a off-site backup.

advplyr added a commit that referenced this issue Jun 18, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Jun 18, 2024
@advplyr
Copy link
Owner

advplyr commented Jun 18, 2024

I made an update so that the backup path can be overridden with an environment variable BACKUP_PATH.

It is now stored in server settings so that we can eventually make the path editable in the UI. That may not make it in the next release so for anyone that wants to modify it now will be able to pass in the env variable.

@noja11
Copy link

noja11 commented Jun 19, 2024

It is now stored in server settings so that we can eventually make the path editable in the UI.

Thank you so much for that change!

I just tried an LXC where I edited the audiobookshelf config file at /etc/default/audiobookshelf to include BACKUP_PATH. As that didn't work yet, I'm assuming I'll need to wait for the next release after 2.10.1?

Again, thank you so much for this quality of life upgrade, I really appreciate it!

@nichwall
Copy link
Contributor

nichwall commented Jun 19, 2024

Yes, you'll need to either way for the next release, build form source, or use the edge docker image.

advplyr added a commit that referenced this issue Jun 19, 2024
- Added api endpoint PATCH /api/backups/path
- Cleanup backup page UI for mobile screens
@advplyr
Copy link
Owner

advplyr commented Jun 19, 2024

I added the ability to edit the path in the UI for the next release. If you have used an env variable to set the backup path then it will be reverted to use the env variable path on a server restart. A warning will be showed in the logs in that case.

image

image

nichwall pushed a commit to nichwall/audiobookshelf that referenced this issue Jun 21, 2024
nichwall pushed a commit to nichwall/audiobookshelf that referenced this issue Jun 21, 2024
- Added api endpoint PATCH /api/backups/path
- Cleanup backup page UI for mobile screens
@advplyr
Copy link
Owner

advplyr commented Jul 9, 2024

Added in v2.11.0

@advplyr advplyr closed this as completed Jul 9, 2024
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants