Prevent backup path edits when ENV is set #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint, remove from ServerConfig
|
Thanks! I didn't see a reason to persist that variable in server config so I updated it to use the value returned from the API call. |
|
Thanks! That makes more sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the backup path from being edited in the web interface if the
BACKUP_PATHenvironment variable is set. This is done to help prevent users from thinking their backup settings are not being applied correctly if they are not looking at the debug logs on server start as mentioned here #2973 (comment).I changed the response for a
GETrequest to/api/backupsto include an additional value of whether this field can be editable, and set this value in the server settings in the same places where the ENV variable is checked.Tested with setting and removing the ENV variable to make sure that the field is then editable.
View with environment variable not set:
View with environment variable set:
