Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove duplicate function in classification/tests/test_base.py #119

Closed
TonyBagnall opened this issue Feb 26, 2023 · 7 comments · Fixed by #120
Closed

[BUG] Remove duplicate function in classification/tests/test_base.py #119

TonyBagnall opened this issue Feb 26, 2023 · 7 comments · Fixed by #120
Labels
bug Something isn't working classification Classification package good first issue Good for newcomers

Comments

@TonyBagnall
Copy link
Contributor

TonyBagnall commented Feb 26, 2023 •
edited
Loading

somehow, we have written the same function twice :) They are both used so pick one, change the uses and get rid of the other.
(unless I am missing something @MatthewMiddlehurst )
image
@TonyBagnall TonyBagnall added bug Something isn't working good first issue Good for newcomers classification Classification package labels Feb 26, 2023
@scorcism
Copy link
Contributor

Hello there,
I'm willin to work of this issue

@TonyBagnall
Copy link
Contributor Author

great, thanks, go for it, any questions, just ask

@scorcism
Copy link
Contributor

Whose code block shoud I remove ?

@TonyBagnall
Copy link
Contributor Author

thats fine, please do make a PR

scorcism added a commit to scorcism/scikit-time that referenced this issue Feb 27, 2023
@scorcism
update test_base.py : remove duplicate function
9c44994 
[BUG] Remove duplicate function in classification/tests/test_base.py aeon-toolkit#119
@TonyBagnall
Copy link
Contributor Author

be warned, the CI takes a looooong time, we are working on it :)

@scorcism scorcism mentioned this issue Feb 27, 2023
Merged
3 tasks
@scorcism
Copy link
Contributor

ohh okay

@scorcism
Copy link
Contributor

I have made the PR

TonyBagnall pushed a commit that referenced this issue Feb 27, 2023
@scorcism
Remove duplicate function (#120)
9b480f9 
* update test_base.py : remove duplicate function

[BUG] Remove duplicate function in classification/tests/test_base.py #119

* Update .all-contributorsrc

* fix naming issue 

Remove duplicate function

* Update test_base.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working classification Classification package good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate function scorcism/scikit-time
2 participants
@TonyBagnall @scorcism