-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate function #120
Conversation
[BUG] Remove duplicate function in classification/tests/test_base.py aeon-toolkit#119
I don't know why this gave so many failed test results :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, you will need to change the calls to _create_nested_dataframe too
test_X3 = _create_nested_dataframe(5, 1, 10)
test_X4 = _create_nested_dataframe(5, 3, 10)
if you look here |
Hey @TonyBagnall, The functions which are duplicate have different names and i removed the function which text_X3 and test_X4 uses : https://imgur.com/HHwMhr6.png |
I have to make
To
|
I have made the changes |
Remove duplicate function
you need to keep _create_example_dataframe, delete _create_nested_dataframe and then change the calls to _create_nested_dataframe so that _create_example_dataframe is called instead. |
so, basically I have to change calls for |
[BUG] Remove duplicate function in classification/tests/test_base.py #119
Reference Issues/PRs
Fixes #119 [BUG] Remove duplicate function in classification/tests/test_base.py
What does this implement/fix? Explain your changes.
Removed a duplicate function inside classification/tests/test_base.py
Does your contribution introduce a new dependency? If yes, which one?
No
For all contributions