Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Negative binomial gibbs sampler #9

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

rlouf
Copy link
Member

@rlouf rlouf commented Feb 15, 2022

In this PR I add some documentation to the existing gibbs samplers, and minor simplifications to the API.

@rlouf rlouf requested a review from zoj613 February 15, 2022 13:57
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #9 (dbdcf61) into main (5edcecd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           99        99           
  Branches         6         6           
=========================================
  Hits            99        99           
Impacted Files Coverage Δ
aemcmc/negative_binomial_horseshoe_gibbs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edcecd...dbdcf61. Read the comment docs.

@brandonwillard brandonwillard added the documentation Improvements or additions to documentation label Feb 15, 2022
@zoj613
Copy link
Member

zoj613 commented Feb 16, 2022

Looks good, aside from the error in lambda's exponent in the model specification docstring.

@rlouf
Copy link
Member Author

rlouf commented Feb 16, 2022

Thank you for the review. I included the changes you suggested. Ready to merge on my end (I need an approving review to be able to merge the PR).

@rlouf rlouf requested a review from zoj613 February 16, 2022 14:01
@zoj613
Copy link
Member

zoj613 commented Feb 16, 2022

Thank you for the review. I included the changes you suggested. Ready to merge on my end (I need an approving review to be able to merge the PR).

done, in case you didnt see the approval.

@rlouf
Copy link
Member Author

rlouf commented Feb 16, 2022

Yes thank you, I don't have merging rights on this repo unfortunately.

@zoj613
Copy link
Member

zoj613 commented Feb 16, 2022

Yes thank you, I don't have merging rights on this repo unfortunately.

Cc @brandonwillard

I'll merge it myself in the meantime.

@zoj613 zoj613 changed the title Document the samplers Document the Negative binomial gibbs sampler Feb 16, 2022
@zoj613 zoj613 merged commit 0b239a0 into aesara-devs:main Feb 16, 2022
@zoj613
Copy link
Member

zoj613 commented Feb 16, 2022

Thanks @rlouf

@rlouf rlouf deleted the return-kernel branch March 21, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants