Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken GEMM C implementation when using NumPy >= 1.23 #1220

Closed
brandonwillard opened this issue Sep 28, 2022 · 0 comments · Fixed by #1219
Closed

Broken GEMM C implementation when using NumPy >= 1.23 #1220

brandonwillard opened this issue Sep 28, 2022 · 0 comments · Fixed by #1219
Labels
bug Something isn't working C-backend help wanted Extra attention is needed important NumPy compatibility

Comments

@brandonwillard
Copy link
Member

It looks like numpy/numpy#21477 (i.e. NumPy >= 1.23) is causing issues in the C implementation of GEMM.

Here's some example test output illustrating the difference:

# Using NumPy 1.23.3
tests/tensor/test_blas.py::TestGemm::test_shape_0
x.shape=(0, 5), x.strides=(0, 0)
y.shape=(5, 4), y.strides=(16, 4)
z.shape=(0, 4), z.strides=(0, 0)
...
# Using NumPy 1.22.3
tests/tensor/test_blas.py::TestGemm::test_shape_0
x.shape=(0, 5), x.strides=(20, 4)
y.shape=(5, 4), y.strides=(16, 4)
z.shape=(0, 4), z.strides=(16, 4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C-backend help wanted Extra attention is needed important NumPy compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant