Fix outdated stride logic in GEMM's C implementation
#1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
previously approved these changes
Sep 28, 2022
brandonwillard
changed the title
jaxlib version restrictions in CIGEMM's C implementation
1 task
brandonwillard
force-pushed
the
remove-jaxlib-pin
branch
from
8086efe to
375d016
Compare
brandonwillard
force-pushed
the
remove-jaxlib-pin
branch
from
375d016 to
3bf3506
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
- Coverage 79.14% 79.09% -0.06%
==========================================
Files 173 173
Lines 48486 48486
Branches 10966 10966
==========================================
- Hits 38376 38349 -27
- Misses 7607 7642 +35
+ Partials 2503 2495 -8
|
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1220.
It looks like
jaxlibhas been update and is now required (e.g. here), so this PR reverts the CI version pin, as well.