-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New DimShuffle C-code fails on Windows #707
Comments
Quick Google suggests it may be a reference count issue: https://stackoverflow.com/a/64960890 |
What's the |
|
Any ideas on a path forward here? |
Someone with a good Windows development setup that can reproduce the issue needs to start debugging it. My first assumption is that this is just another reference count problem. Hopefully, there's just a bug in the new implementation and one can find it by manually tracking the reference counts (e.g. print them all throughout the Worst case, the issue could be caused by a CPython version/implementation discrepancy and the above might fix things for Windows but break things in Linux (or introduce a memory leak). Regardless, someone needs to do some simple debugging (and not forget to |
The issue seems to be the use of |
👍 how painful was that to find? |
It took literally five minutes to find it after about an hour of building a Windows VM, setting up a dev environment, finding out how nearly impossible it is to get |
This was first seen in pymc-devs/pymc#5279
The following tests are failing on my Windows machine:
test_elemwise.py::TestDimShuffle::test_infer_shape
test_elemwise.py::TestDimShuffle::test_too_big_rank
test_elemwise.py::TestDimShuffle::test_c_views
The first two tests which precede #701 pass before the relevant commit: e593b0a and fail after.
For sanity check, all tests in
test_elemwise.py::TestBroadcast
work fine in main.Traceback
When running
test_elemwise.py::TestDimShuffle::test_c_views
:Versions and main components
python -c "import aesara; print(aesara.config)"
)And then removed aesara with
conda remove --force aesara
to use the local branchThe text was updated successfully, but these errors were encountered: