Fix bad Windows free in dimshuffle.c
#762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
changed the title
dimshuffle.c
twiecki
reviewed
Jan 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 78.34% 78.34%
=======================================
Files 152 152
Lines 47656 47656
Branches 10876 10876
=======================================
Hits 37337 37337
Misses 7772 7772
Partials 2547 2547 |
|
Awesome, and can we cut a new aesara release with this? |
Just did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #707.
It looks like the
PyDimMem_FREEmacro can have two different behaviors, and one of them doesn't match the explicit use ofmalloc. The changes here make the allocation and deallocation approaches match.