-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Top accounts #634
feat: Top accounts #634
Conversation
Deployed to https://pr-634-aescan.stg.service.aepps.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janmichek I have questions:
- According to Top Accounts Info: The top accounts are the accounts with the highest balance of AE coins. But I can see in the list that many accounts have 0 balance now and the last Tx was 10 months ago or 1-2 year ago. Is this correct order?
2023-12-29.5.33.34.mov
- According to Add top accounts page #616 description A new table should contain the following columns:
- Hash
- Balance
- % Of Circulating
but I see different columns:
- Rank
- Account
- % Of Circulating
Good catch, was not checking it. I reported this to MDW aeternity/ae_mdw#1661 and putting this issue On Hold until resolved |
Balance added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's better comparing to previous version. LGTM.
The last issue is remaining about accounts balances, waiting for mdw resolving.
Closing this until the issue is not fixed on the mdw. |
Description
resolves #616
/top-accounts
URL. The entripoint is a part of new menu here feat: New menu structure #627Demo
Checklist: