WIP: Use THREE.DeviceOrientationControls when webvrpolyfill is not used #4355 #4361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Device orientation is not taken into account anymore on Chrome m79 (related to issue #4355).
The component
look-controls
usesPolyfillControls
See:
look-controls.js:34
device.js:189
device.js
, first it retrieves the VR display using the polyfillPolyfillControls#update
, a check to see if there is a vr display. If there is none, it short circuits.This PR tries to change the working logic as little as possible.
Changes proposed:
super-three/examples/js/controls/DeviceOrientationControls
intoTHREE
namespaceTHREE.DeviceOrientationControls
Questions:
polyfillControls
andpolyfillObject
?window.webvrpolyfill
presence enough?