Android magic window #4363
Merged
Android magic window #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
force-pushed
the
androidMagicWindow
branch
from
907e76f to
3081935
Compare
… DeviceOrientationControls without the DeviceOrientationEvent.requestPermission logic that is handled by A-Frame (fix aframevr#4355) Co-authored-by: MK <maxence@lucidweb.io> Co-authored-by: Diego Marcos <diego.marcos@gmail.com>
dmarcos
force-pushed
the
androidMagicWindow
branch
from
3081935 to
4699cad
Compare
| // Only on mobile devices and only enabled if DeviceOrientation permission has been granted. | ||
| if (utils.device.isMobile()) { | ||
| magicWindowControls = this.magicWindowControls = new THREE.DeviceOrientationControls(this.magicWindowObject); | ||
| if (typeof DeviceOrientationEvent === 'undefined' && DeviceOrientationEvent.requestPermission) { |
There was a problem hiding this comment.
I think the condition is always false. How can requestPermission exist if DeviceOrientationEvent is undefined?
| magicWindowControls = this.magicWindowControls = new THREE.DeviceOrientationControls(this.magicWindowObject); | ||
| if (typeof DeviceOrientationEvent === 'undefined' && DeviceOrientationEvent.requestPermission) { | ||
| magicWindowControls.enabled = false; | ||
| if (this.el.sceneEl.components['device-orientation-permission-ui'].premissionGranted) { |
There was a problem hiding this comment.
there is a typo here premissionGranted => permissionGranted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.