Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The first user suggested name is ... undefined #1364

Closed
kobliha opened this issue Jun 20, 2024 · 3 comments
Closed

The first user suggested name is ... undefined #1364

kobliha opened this issue Jun 20, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Agama 9

Comments

@kobliha
Copy link
Contributor

kobliha commented Jun 20, 2024

Suggested username - undefined

It's not mandatory to define a real user name, but even then Agama proposes a username (login). Sadly, it's "undefined" :) Which is not wrong per-se as it's at least gender-neutral.

How to reproduce?

  1. Surf to the User -> First user
  2. Define a user now
  3. Click into the Full Name field
  4. Don't enter anything
  5. Click into the Username field
  6. You are offered to add the "undefined" user

Looks like Agama is storing undefined as the user on leaving the field even when nothing is really entered.
@kobliha
Copy link
Contributor Author

kobliha commented Jun 20, 2024

User Full Name is required

Additionally to that, the Full name is actually required although it's not marked that way. Behaves the same when creating new or editing a user.

@imobachgs
Copy link
Contributor

A funny one, indeed. About the required fields, it is in our todo list. We decided to not mark any field with the asterisk but we are not there yet :-/

@imobachgs imobachgs added bug Something isn't working good first issue Good for newcomers labels Jun 20, 2024
@imobachgs imobachgs added this to the Agama 9 milestone Jun 25, 2024
@dgdavid dgdavid mentioned this issue Jun 25, 2024
Merged
dgdavid added a commit that referenced this issue Jun 25, 2024
@dgdavid
fix(web) improve first user form (#1374)
100672e 
## Problem

#1364 reported two small
problems in the first user form:

* The lack of red asterisk in some mandatory fields
* The presence of "undefined" suggestion for the username field when the
name has not been given.

## Solution

To show suggestions only when it make sense and to drop the required
mark from the username field. As said in a commit, after Agama 9 the
forms and its required fields are going to be improved.

## Testing

- Tested manually
@dgdavid
Copy link
Contributor

dgdavid commented Jun 25, 2024

Fixed in #1374

@dgdavid dgdavid closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Agama 9
Development

No branches or pull requests
3 participants
@imobachgs @kobliha @dgdavid