Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web) improve first user form #1374

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix(web) improve first user form #1374

merged 2 commits into from
Jun 25, 2024

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Jun 25, 2024 •
edited
Loading

Problem

#1364 reported two small problems in the first user form:

  • The lack of red asterisk in some mandatory fields
  • The presence of "undefined" suggestion for the username field when the name has not been given.

Solution

To show suggestions only when it make sense and to drop the required mark from the username field. As said in a commit, after Agama 9 the forms and its required fields are going to be improved.

Testing

  • Tested manually

@dgdavid
fix(web): users: does not suggest "undefined" username
1701ab1
@dgdavid
fix(web): users: drop the "isRequired" from username
33d2fdc 
Since currently all the fields are required and we do not have neither,
a way for adding the isRequired mark to password inputs nor an
explanation in the UI for telling the user what the red asterisk means.

The whole thing will be addressed after Agama 9.
@dgdavid dgdavid requested a review from imobachgs June 25, 2024 11:32
@dgdavid dgdavid changed the title fix(web) Fix some issues in the first user form fix(web) improve first user form Jun 25, 2024
@dgdavid dgdavid merged commit 100672e into master Jun 25, 2024
2 checks passed
@dgdavid dgdavid deleted the fix-first-user branch June 25, 2024 12:01
@dgdavid dgdavid mentioned this pull request Jun 25, 2024
Closed
@imobachgs imobachgs added this to the Agama 9 milestone Jun 25, 2024
@imobachgs imobachgs mentioned this pull request Jun 27, 2024
Merged
imobachgs added a commit that referenced this pull request Jun 27, 2024
@imobachgs
Update to release 9 (#1404)
8fe19db 
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Agama 9
Development

Successfully merging this pull request may close these issues.
2 participants
@dgdavid @imobachgs