Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web) improve first user form #1374

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix(web) improve first user form #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1701ab1
fix(web): users: does not suggest "undefined" username
dgdavid Jun 25, 2024
33d2fdc
fix(web): users: drop the "isRequired" from username
dgdavid Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion web/src/components/users/FirstUserForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ export default function FirstUserForm() {
className="first-username-wrapper"
fieldId="userName"
label={_("Username")}
isRequired
>
<TextInput
id="userName"
Expand Down
2 changes: 2 additions & 0 deletions web/src/components/users/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
* @returns {string[]} An array of username suggestions.
*/
const suggestUsernames = (fullName) => {
if (!fullName) return [];

// Cleaning the name.
const cleanedName = fullName
.normalize('NFD')
Expand Down
5 changes: 5 additions & 0 deletions web/src/components/users/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@
import { suggestUsernames } from "./utils";

describe('suggestUsernames', () => {
test('returns empty collection if fullName not defined', () => {
expect(suggestUsernames(undefined)).toEqual([]);
expect(suggestUsernames(null)).toEqual([]);
});

test('handles basic single name', () => {
expect(suggestUsernames('John')).toEqual(expect.arrayContaining(['john']));
});
Expand Down
Loading