Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add a "config edit" command #1360

Merged
merged 4 commits into from
Jun 20, 2024
Merged

feat(cli): add a "config edit" command #1360

merged 4 commits into from
Jun 20, 2024

Conversation

imobachgs
Copy link
Contributor

This PR adds a new feature to load and save the current configuration using an external editor. It is still a work in progress but it already works.

Edit the user and select a product
Grabacion.de.pantalla.desde.2024-06-20.07-22-33.webm

Additional changes

  • Dropped the --format option as it is not expected to work with a format different from JSON.
  • Improve JSON formatting (by using serde_json::to_string_pretty().

Base automatically changed from better-progress to master June 20, 2024 12:02
@imobachgs imobachgs force-pushed the config-edit branch 2 times, most recently from 6d40cdc to 16d631e Compare June 20, 2024 12:45
@imobachgs imobachgs marked this pull request as ready for review June 20, 2024 12:57
@agama-project agama-project deleted a comment from coveralls Jun 20, 2024
@agama-project agama-project deleted a comment from coveralls Jun 20, 2024
@agama-project agama-project deleted a comment from coveralls Jun 20, 2024
@agama-project agama-project deleted a comment from coveralls Jun 20, 2024
@agama-project agama-project deleted a comment from coveralls Jun 20, 2024
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. LGTM

@imobachgs imobachgs merged commit be7223d into master Jun 20, 2024
2 checks passed
@imobachgs imobachgs deleted the config-edit branch June 20, 2024 15:29
@imobachgs imobachgs added this to the Agama 9 milestone Jun 25, 2024
@imobachgs imobachgs mentioned this pull request Jun 27, 2024
imobachgs added a commit that referenced this pull request Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants