Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): drop "agama config add/set" subcommands #1314

Merged
merged 9 commits into from
Jun 12, 2024
Merged

feat(cli): drop "agama config add/set" subcommands #1314

merged 9 commits into from
Jun 12, 2024

Conversation

imobachgs
Copy link
Contributor

Problem

Agama CLI supports setting specific values directly via the CLI. Check agama config --help to learn more. However, it has a few problems:

  • It is not finished yet, especially when it comes to handle collections.
  • How useful is for real use cases (instead of just using config load)? We have some examples in the documentation, but nothing critical.
  • Users could manipulate the configuration by using a tool like jq.

Solution

Just drop the agama config add/set subcommands.

@imobachgs imobachgs changed the title Drop settings feat(cli): drop "agama config add/set" subcommands Jun 11, 2024
@imobachgs imobachgs marked this pull request as ready for review June 11, 2024 21:40
@coveralls
Copy link

Coverage Status

coverage: 70.768% (+0.4%) from 70.38%
when pulling 0851669 on drop-settings
into b2d7fca on master.

joseivanlopez
joseivanlopez approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit c405230 into master Jun 12, 2024
2 checks passed
@imobachgs imobachgs deleted the drop-settings branch June 12, 2024 07:45
@imobachgs imobachgs mentioned this pull request Jun 27, 2024
Merged
imobachgs added a commit that referenced this pull request Jun 27, 2024
@imobachgs
Update to release 9 (#1404)
8fe19db 
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseivanlopez joseivanlopez joseivanlopez approved these changes

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imobachgs @coveralls @joseivanlopez @dgdavid