-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): load storage config for guided proposal #1293
Conversation
486750e
to
2c5fcae
Compare
01b8f90
to
7c348ca
Compare
8222fdf
to
f515b56
Compare
f515b56
to
2e3278b
Compare
pub async fn set_config(&self, settings: StorageSettings) -> Result<u32, ServiceError> { | ||
Ok(self | ||
.storage_proxy | ||
.set_config(serde_json::to_string(&settings).unwrap().as_str()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: I know we are kind of in a hurry, but in the future we should drop this call to unwrap
.
/// Get the storage config according to the JSON schema | ||
pub async fn get_config(&self) -> Result<StorageSettings, ServiceError> { | ||
let serialized_settings = self.storage_proxy.get_config().await?; | ||
let settings = serde_json::from_str(serialized_settings.as_str()).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same than above.
|
||
# Performs conversion from Hash according to the JSON schema. | ||
# | ||
# @param schema_settings [Hash] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What "schema" means? For me, the "schema" is the JSON specification. On IRC we decided to address this issue later.
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
Add CLI support for setting and getting the storage config.
Load (set) storage settings from a config file:
Config for a guided proposal:
Config for an AutoYaST proposal:
Recover (get) the storage config:
NOTES