-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network improvements #1365
Network improvements #1365
Conversation
72abba0
to
f7334f1
Compare
ad385d0
to
ca826a8
Compare
1c0dbb7
to
143be2f
Compare
Co-authored-by: Knut Anderssen <kanderssen@suse.com>
Co-authored-by: Knut Anderssen <kanderssen@suse.com>
This commit includes two major changes: - To avoid an infinite loop when fetching network data by making use of React.useCallback. - To persist the selected WiFi network to localStorage to mitigate an UI glitch due to the fact that the whole component gets unmounted on websocket reconnection.
No matter if user accepts or cancel the edition, the router should navigate back to the previous route instead to the parent route.
143be2f
to
6fed0a0
Compare
Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
const [devices, setDevices] = useState(undefined); | ||
const [selectedConnection, setSelectedConnection] = useState(null); | ||
const [devices, setDevices] = useState(initialDevices); | ||
const [updateState, setUpdateState] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is updateState
used? Perhaps a better name could help to know the intention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was updateNetworks, as the method was get from WifiSelector and updateDevicesConnections was like too much.. was not very inspired at the moment of writing it :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, it is wrong because we are not checking the updateState
value.
<CardField> | ||
<CardField.Content> | ||
<EmptyState title={_("No WiFi support")} icon="wifi_off" color="warning-color-200"> | ||
{_("The system does not support WiFi connections, probably because of missing or disabled hardware.")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put in the shoes of an inexperienced user... I do not know if "missing hardware" is good enough.
47c2039
to
c2340b7
Compare
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
Description
Network was one of the first components we added to Agama and since then it the components have evolve a lot being one of the most out of date ones. Therefore it was known it deserve some love... and we tried to start revamping it a little bit.
Changes done:
Manually tested
Pending:
Old UI
New UI