Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): avoid segmentation fault when generating actions #1379

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jun 25, 2024

Problem

In the Agama ISO there is a segmentation fault when generating the storage actions, see #1377.

Solution

Keep a reference to the used actiongraph to avoid the gargabe collector to kill it.

@coveralls
Copy link

Coverage Status

coverage: 70.99%. remained the same
when pulling 923be10 on fix-actions
into ce30ede on master.

@coveralls
Copy link

Coverage Status

coverage: 71.008% (+0.02%) from 70.99%
when pulling d970258 on fix-actions
into ce30ede on master.

@coveralls
Copy link

Coverage Status

coverage: 70.988% (-0.002%) from 70.99%
when pulling d970258 on fix-actions
into ce30ede on master.

@joseivanlopez joseivanlopez marked this pull request as ready for review June 26, 2024 08:18
@joseivanlopez joseivanlopez merged commit 3428c4e into master Jun 26, 2024
7 checks passed
@joseivanlopez joseivanlopez deleted the fix-actions branch June 26, 2024 09:26
joseivanlopez added a commit that referenced this pull request Jun 27, 2024
## Problem

Generating storage actions crashes, see:

* #1396
* #1379

## Solution

Avoid actiongraph clean-up by the ruby GC. 

Note: This is a hot-fix. A better solution is required.
@imobachgs imobachgs mentioned this pull request Jun 27, 2024
imobachgs added a commit that referenced this pull request Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants