improve patterns selector #1248
Conversation
| @@ -166,6 +166,12 @@ function PatternSelector({ patterns, onSelectionChanged = noop }) { | |||
| ); | |||
| }); | |||
|
|
|||
| if (selector.length === 0) { | |||
| selector = ( | |||
| <Label>{_("No results")}</Label> | |||
There was a problem hiding this comment.
I'would not use the <Label> component for this kind of things. Not even the Patternfly guys would use it either 😉
Not saying we have to follow strictly their design guidelines, but in this case I'm more aligned with them.
Use just plain old HTML like <span>, <b> or even <strong> if we considered it is something should be emphasise.
Also, do not hesitate of adding more text to make it clear. I cannot help too much with texts, but "No matches" looks a bit poor to me.
| if (selector.length === 0) { | ||
| selector = ( | ||
| <b>{_("None of the patterns match the text.")}</b> | ||
| ); | ||
| } |
There was a problem hiding this comment.
NP:
Sorry, I didn't realize before, but it is actually not needed to redefine the selector variable. You can just change {selector} to {selector.length ? selector : <NoResultFoundThing />} below. But don't worry and keep it as it is to minimize the conflicts with the new-ui branch.
Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
Problem
There is broken counter how in search box for pattern selector. Also there is no clear indication that nothing is matched.
Solution
See screenshots how it is improved:
Old:
counter:
empty result:
New:
counter:
empty result (attempt 1):
empty result (attempt 2):
