[web] Drop Section#openDialog prop #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was there almost from the beginning for allowing allowing a modal dialog to be opened directly from a section title. However, as the installer has evolved, we have limited the title behavior to navigation only which is more expected and less confusing. If a section needs to open a dialog it's better to use an explicit option inside the section content instead of hiding these options behind the section header. We can reintroduce the feature in the future if really needed, but maintaining it just in case isn't an option.
dgdavid
force-pushed
the
remove-open-dialog-from-section
branch
from
2b1c5f0
to
02fd153
Compare
imobachgs
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some time ago, we introduced in the Agama core/Section component a feature to allow a modal dialog to be opened directly from the section title. However, as the installer has evolved, we have limited the title behavior to navigation only, which is more expected and less confusing. Thus, such a feature is actually not in use.
Solution
Although additional features rarely cause problems, it's best to keep components as simple and clean as possible. Also, at this time, we believe it is more straightforward to use an explicit option inside the section to open a dialog than to hide it behind the header.
Therefore, this PR drops the mentioned feature. If we find a very compelling and valid use case, we can reintroduce it.
Testing