[web] Simplify code of Section component #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Section#SectionIcon#size was no really in use, just falling back to its default value. Section#SectionIcon#aria-hidden attribute is not needed since the core/Icon component already sets it.
Using less internal components.
imobachgs
approved these changes
Nov 2, 2023
dgdavid
force-pushed
the
simplify-section-component
branch
from
480e2a1
to
597e710
Compare
dgdavid
force-pushed
the
simplify-section-component
branch
from
597e710
to
d687cfc
Compare
imobachgs
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While working in #838 a few code improvements for simplifying Agama/Section component were identified.
Solution
Apply them.
Testing