Add run_id for single-turn workflows#152
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily introduces a standardized mechanism for assigning a unique, sequential run_id to each generated response within several single-turn workflow implementations. This enhancement improves the traceability and identification of individual responses, which can be crucial for logging, debugging, and analysis. Additionally, it includes a minor update to the add_strategy module to expose newly defined strategy classes.
Highlights
- Run ID Assignment: Implemented the assignment of a sequential
run_idto each response generated within single-turn workflows by utilizingenumerateduring iteration over responses. Thisrun_idis stored inresponse.eid.run. - Workflow Standardization: Applied the
run_idassignment logic consistently acrosscustomized_math_workflows.py,customized_toolcall_workflows.py,math_rm_workflow.py, andworkflow.pyto ensure uniform tracking of individual runs within a batch. - Strategy Module Updates: Updated
trinity/algorithm/add_strategy/__init__.pyto import and exposeGRPOAddStrategyandOPMDAddStrategy, making these new strategy classes available for use.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
/unittest-module-explorer |
There was a problem hiding this comment.
Code Review
This pull request adds a run_id to experiences generated in single-turn workflows. The changes are consistently applied across multiple workflow files. Consider addressing the comment about the scope of the PR in trinity/algorithm/add_strategy/__init__.py. Also, consider adding comments to explain the purpose of the run_id variable and how it relates to the experience being generated.
|
/unittest-module-explorer |
|
/unittest-module-explorer |
Summary
Tests
Github Test Reporter by CTRF 💚 |
2 participants
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.