Skip to content

Add run_id for single-turn workflows #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiyuchang merged 2 commits into from
Jul 31, 2025
Merged

Add run_id for single-turn workflows #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d220f59
add run_id
hiyuchang Jul 30, 2025
7242c07
Merge branch 'main' into feat/fix_eidrun
hiyuchang Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions trinity/algorithm/add_strategy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
from trinity.algorithm.add_strategy.add_strategy import (
ADD_STRATEGY,
AddStrategy,
GRPOAddStrategy,
OPMDAddStrategy,
RewardVarianceAddStrategy,
)

__all__ = [
"ADD_STRATEGY",
"AddStrategy",
"GRPOAddStrategy",
"OPMDAddStrategy",
"RewardVarianceAddStrategy",
]
3 changes: 2 additions & 1 deletion trinity/common/workflows/customized_math_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def run(self) -> List[Experience]:
else:
responses = self.model.generate([prompt_text], **self.rollout_args)

for response in responses:
for run_id, response in enumerate(responses):
reward_dict = self.reward_fn( # type: ignore [misc]
response=response.response_text, # type: ignore [arg-type]
truth=self.truth,
Expand All @@ -89,6 +89,7 @@ def run(self) -> List[Experience]:
response.metrics.update(reward_dict)
reward = sum(reward_dict.values())
response.reward = reward
response.eid.run = run_id

if not self.use_base:
logger.debug(
Expand Down
4 changes: 2 additions & 2 deletions trinity/common/workflows/customized_toolcall_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def run(self) -> List[Experience]:
logger.debug("start chat")
responses = self.model.chat(messages, **self.rollout_args)

for i, response in enumerate(responses):
for run_id, response in enumerate(responses):
reward = 0.0

if self.raw_task is not None:
Expand All @@ -267,5 +267,5 @@ def run(self) -> List[Experience]:
f"self.task_desc: {self.task_desc}, messages: {messages}, response: {response.response_text}, reward: {reward}"
)
response.reward = reward
response.eid.run = i
response.eid.run = run_id
return responses
3 changes: 2 additions & 1 deletion trinity/common/workflows/math_rm_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def run(self) -> List[Experience]:

logger.debug("start chat")
responses = self.model.chat(messages, **self.rollout_args)
for response in responses:
for run_id, response in enumerate(responses):
reward_dict = self.reward_fn( # type: ignore
response,
messages,
Expand All @@ -48,6 +48,7 @@ def run(self) -> List[Experience]:
response.metrics.update(reward_dict)
reward = sum(reward_dict.values())
response.reward = reward
response.eid.run = run_id

logger.debug(
f"self.task_desc: {self.task_desc}, messages: {messages}, response: {response.response_text}, reward: {reward}"
Expand Down
3 changes: 2 additions & 1 deletion trinity/common/workflows/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def run(self) -> List[Experience]:

logger.debug("start chat")
responses = self.model.chat(messages, **self.rollout_args)
for response in responses:
for run_id, response in enumerate(responses):
reward_dict = self.reward_fn( # type: ignore [misc]
response=response.response_text, # type: ignore [arg-type]
truth=self.truth,
Expand All @@ -226,6 +226,7 @@ def run(self) -> List[Experience]:
response.metrics.update(reward_dict)
reward = sum(reward_dict.values())
response.reward = reward
response.eid.run = run_id

logger.debug(
f"self.task_desc: {self.task_desc}, messages: {messages}, response: {response.response_text}, reward: {reward}"
Expand Down