Deploy Gaia-X Authority did document #175

Izzzu · 2022-06-29T12:37:46Z

Deployment of GAIA-X Authority DID in Deploy pipeline.
DID document contains public key in the same format as Registration Service did document.

Further notes

renaming the registry to either authority for did document resources and registrationservice for Registration Service resources for consistency
removing branches: [ main ] from CD workflow to enable checks in all PRs

linked to #151

.github/workflows/deploy.yaml

deployment/terraform/dataspace/variables.tf

.github/workflows/cd.yaml

chrislomonico

Please review comments provided

algattik

The DID and private key are related not just to "registration service", but really to "dataspace authority" which is more than that. Names should reflect this

Izzzu · 2022-07-01T09:19:51Z

The DID and private key are related not just to "registration service", but really to "dataspace authority" which is more than that. Names should reflect this

indeed, I renamed the registry to either authority for did document resources and registrationservice for Registration Service resources

algattik · 2022-07-01T11:54:51Z

.github/actions/generate-key/action.yml

@@ -0,0 +1,18 @@
+name: "Generate key"
+description: "Generate key"


could we extend this description

algattik · 2022-07-01T11:55:08Z

.github/actions/generate-key/action.yml

+
+inputs:
+  keyname:
+    description: 'Name of the key file name'


Suggested change

description: 'Name of the key file name'

description: 'Prefix for key file names'

algattik · 2022-07-01T11:55:20Z

.github/actions/generate-key/action.yml

+runs:
+  using: "composite"
+  steps:
+    - name: 'Generate GAIA-X Authority key'


needs generalisation

algattik · 2022-07-01T11:55:56Z

.github/actions/generate-key/action.yml

+description: "Generate key"
+
+inputs:
+  keyname:


Suggested change

keyname:

keyFileNamePrefix:

algattik · 2022-07-01T11:56:34Z

.github/workflows/deploy.yaml

+      - name: 'Generate Dataspace Authority key'
+        uses: ./.github/actions/generate-key
+        with:
+          keyname: registrationservicekey


Suggested change

keyname: registrationservicekey

keyname: authoritykey

algattik · 2022-07-01T11:56:56Z

.github/workflows/deploy.yaml

-          openssl ecparam -name prime256v1 -genkey -noout -out key.pem
-          openssl ec -in key.pem -pubout -out key.public.pem
-          docker run -i danedmunds/pem-to-jwk:1.2.1 --public --pretty < key.public.pem > key.public.jwk
+      - name: 'Generate Participant's key'


Suggested change

- name: 'Generate Participant's key'

- name: 'Generate Participant key'

algattik · 2022-07-01T11:57:40Z

deployment/terraform/dataspace/main.tf

      }
    ],
    "verificationMethod" = [
      {
-        "id"           = "#identity-key-1"
+        "id"           = "#identity-key-registration-service"


Suggested change

"id" = "#identity-key-registration-service"

"id" = "#identity-key-authority"

chrislomonico

open questions/comments addressed

cpeeyush

Approved with suggestions which can be discussed later, no action needed for this PR at the moment. Thank you.

cpeeyush · 2022-07-04T15:08:03Z

deployment/terraform/dataspace/variables.tf

+variable "key_file_authority" {
+  description = "name of a file containing the Registration Service private key in PEM format"


nit: By reading description and the variable name it gives the impression that authority and registration service are related as its usage registration service private key as per the description.

No action needed on this PR but we can discuss it later.

cpeeyush · 2022-07-04T15:10:16Z

deployment/terraform/dataspace/main.tf

-  key_vault_id = azurerm_key_vault.registry.id
+  count        = var.key_file_authority == null ? 0 : 1
+  value        = file(var.key_file_authority)
+  key_vault_id = azurerm_key_vault.registrationservice.id


nit: Same as below comment, If registration service does not need a key vault, then maybe we do not deploy one for that and rename to authority as currently in this PR registration service key vault is used to store authority did private key only.

No action for now can be discussed in a follow-up PR.

* Deploy Gaia-X Authority did document (#175) * Rename 'registry' to 'registration service' consistently (#196)

Izzzu added 4 commits June 29, 2022 14:33

Deploy GaiaX-Authority did

e8ae6f9

Deploy GaiaX-Authority did

d389c10

Deploy GaiaX-Authority did

aef8954

Deploy GaiaX-Authority did

3af16a1

Izzzu changed the base branch from feature/151-gaiax-did to main June 29, 2022 13:17

Izzzu added 2 commits June 29, 2022 15:17

Deploy GaiaX-Authority did

166573c

Terraform format

26b165c

Izzzu changed the title ~~Deploy GaiaX-Authority did~~ Deploy Gaia-X Authority did document Jun 29, 2022

Izzzu changed the base branch from main to feature/151-gaiax-did June 29, 2022 13:59

Izzzu marked this pull request as ready for review June 29, 2022 14:00

algattik requested changes Jun 30, 2022

View reviewed changes

chrislomonico requested review from chrislomonico and cpeeyush June 30, 2022 08:39

Izzzu added 10 commits June 30, 2022 11:12

Changes after review

2eaf426

Changes after review

d6f467f

Changes after review

797ec85

Changes after review

978a736

Changes after review

c79bb36

Changes after review

e25daaf

Changes after review

943d6e7

Changes after review

ce55503

Changes after review

a4bfbee

Changes after review

030fe92

chrislomonico reviewed Jul 1, 2022

View reviewed changes

deployment/terraform/dataspace/variables.tf Outdated Show resolved Hide resolved

chrislomonico reviewed Jul 1, 2022

View reviewed changes

deployment/terraform/dataspace/variables.tf Outdated Show resolved Hide resolved

algattik mentioned this pull request Jul 1, 2022

Rename 'registry' to 'registration service' consistently #180

Closed

1 task

chrislomonico reviewed Jul 1, 2022

View reviewed changes

.github/workflows/cd.yaml Show resolved Hide resolved

chrislomonico requested changes Jul 1, 2022

View reviewed changes

algattik requested changes Jul 1, 2022

View reviewed changes

Rename registry to authority or registration service

8fbd697

Izzzu added 5 commits July 1, 2022 11:29

Rename registry to authority or registration service

1537497

Rename registry to authority or registration service

694857b

Rename registry to authority or registration service

2d763c0

Terraform format

3032bad

changes after review

3f5207a

algattik reviewed Jul 1, 2022

View reviewed changes

changes after review

7b4bd5c

algattik reviewed Jul 1, 2022

View reviewed changes

Izzzu added 5 commits July 1, 2022 14:20

changes after review

9554745

changes after review

664c102

changes after review

8daa232

changes after review

94950b6

changes after review

f98ea84

chrislomonico approved these changes Jul 4, 2022

View reviewed changes

cpeeyush approved these changes Jul 4, 2022

View reviewed changes

Izzzu merged commit 2827a86 into feature/151-gaiax-did Jul 4, 2022

zeier linked an issue Jul 7, 2022 that may be closed by this pull request

GAIA-X Authority - DID #151

Closed

3 tasks

cpeeyush pushed a commit that referenced this pull request Jul 11, 2022

feat: add GAIA-X DID document deployment (#19)

0bb70e4

* Deploy Gaia-X Authority did document (#175) * Rename 'registry' to 'registration service' consistently (#196)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploy Gaia-X Authority did document #175

Deploy Gaia-X Authority did document #175

Izzzu commented Jun 29, 2022 •

edited

Loading

chrislomonico left a comment

algattik left a comment

Izzzu commented Jul 1, 2022

algattik Jul 1, 2022

algattik Jul 1, 2022

algattik Jul 1, 2022

algattik Jul 1, 2022

algattik Jul 1, 2022

algattik Jul 1, 2022

algattik Jul 1, 2022

chrislomonico left a comment

cpeeyush left a comment

cpeeyush Jul 4, 2022

cpeeyush Jul 4, 2022

		@@ -0,0 +1,18 @@
		name: "Generate key"
		description: "Generate key"

	description: 'Name of the key file name'
	description: 'Prefix for key file names'

	- name: 'Generate Participant's key'
	- name: 'Generate Participant key'

	"id" = "#identity-key-registration-service"
	"id" = "#identity-key-authority"

		variable "key_file_authority" {
		description = "name of a file containing the Registration Service private key in PEM format"

Deploy Gaia-X Authority did document #175

Deploy Gaia-X Authority did document #175

Conversation

Izzzu commented Jun 29, 2022 • edited Loading

Further notes

chrislomonico left a comment

Choose a reason for hiding this comment

algattik left a comment

Choose a reason for hiding this comment

Izzzu commented Jul 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrislomonico left a comment

Choose a reason for hiding this comment

cpeeyush left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Izzzu commented Jun 29, 2022 •

edited

Loading