Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'registry' to 'registration service' consistently #196

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

Izzzu
Copy link

@Izzzu Izzzu commented Jul 7, 2022

Description

A mix of the names 'registry' and 'registration service' to refer to the 'registration service' is confusing.

Especially as deployers need to first deploy an 'azure container registry', which is unrelated.

Therefore, we want to make sure the names are used consistently.

Further notes

Renaming authority_did in terraform files to dataspace_did to not confuse the internal Dataspace DID with the external GAIA-X Authority DID.

linked to #180

@Izzzu Izzzu marked this pull request as ready for review July 7, 2022 09:51
@chrislomonico chrislomonico self-requested a review July 7, 2022 14:20
@@ -208,9 +208,9 @@ jobs:
run: curl https://${{ steps.runterraform.outputs.gaiax_did_host }}/.well-known/did.json | jq '.id'

- name: 'Verify Dataspace Authority did endpoint is available'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: (feel free to ignore)

Suggested change
- name: 'Verify Dataspace Authority did endpoint is available'
- name: 'Verify Dataspace DiD endpoint is available'

Copy link

@chrislomonico chrislomonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit not worth blocking over

@pkirch pkirch self-requested a review July 7, 2022 14:24
@pkirch
Copy link

pkirch commented Jul 7, 2022

Please make the Flow sequence in docs/developer/decision-records/2022-06-15-registration-service/README.md more consistent for Dataspace Registry and Registration Service as discussed. Thanks!

@zeier zeier self-requested a review July 8, 2022 06:55
@zeier zeier linked an issue Jul 8, 2022 that may be closed by this pull request
1 task
Copy link

@zeier zeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Izzzu, we still have a couple of references that use the term Registry in this repo, including RegistryApi, as well as Dataspace Registry in the Registration Service ADR.

The RegistrationService repo uses the term Registry as well.

Do we want to keep this as is, or would it be worthwhile to use the term Registration Service consistently?

@Izzzu
Copy link
Author

Izzzu commented Jul 8, 2022

Please make the Flow sequence in docs/developer/decision-records/2022-06-15-registration-service/README.md more consistent for Dataspace Registry and Registration Service as discussed. Thanks!

Changed as discussed

@Izzzu
Copy link
Author

Izzzu commented Jul 8, 2022

@Izzzu, we still have a couple of references that use the term Registry in this repo, including RegistryApi, as well as Dataspace Registry in the Registration Service ADR.

The RegistrationService repo uses the term Registry as well.

Do we want to keep this as is, or would it be worthwhile to use the term Registration Service consistently?

@zeier RegistryApi and also usage of Registry in Registration Service sound reasonable, because Registration Service manages the participants registry and it exposes the Registry API that offers methods to list and register participant.
So I'd say we don't ned to get rid of the word 'registry', as it's just one component of the registration service, which is one component of the dataspace auhtority.

@Izzzu Izzzu merged commit cbcdc2b into feature/151-gaiax-did Jul 8, 2022
cpeeyush pushed a commit that referenced this pull request Jul 11, 2022
* Deploy Gaia-X Authority did document (#175)

* Rename 'registry' to 'registration service' consistently (#196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename 'registry' to 'registration service' consistently
4 participants