-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'registry' to 'registration service' consistently #196
Conversation
.github/workflows/deploy.yaml
Outdated
@@ -208,9 +208,9 @@ jobs: | |||
run: curl https://${{ steps.runterraform.outputs.gaiax_did_host }}/.well-known/did.json | jq '.id' | |||
|
|||
- name: 'Verify Dataspace Authority did endpoint is available' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: (feel free to ignore)
- name: 'Verify Dataspace Authority did endpoint is available' | |
- name: 'Verify Dataspace DiD endpoint is available' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit
not worth blocking over
Please make the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Izzzu, we still have a couple of references that use the term Registry
in this repo, including RegistryApi
, as well as Dataspace Registry
in the Registration Service ADR.
The RegistrationService repo uses the term Registry
as well.
Do we want to keep this as is, or would it be worthwhile to use the term Registration Service
consistently?
Changed as discussed |
@zeier RegistryApi and also usage of |
Description
A mix of the names 'registry' and 'registration service' to refer to the 'registration service' is confusing.
Especially as deployers need to first deploy an 'azure container registry', which is unrelated.
Therefore, we want to make sure the names are used consistently.
Further notes
Renaming
authority_did
in terraform files todataspace_did
to not confuse the internal Dataspace DID with the external GAIA-X Authority DID.linked to #180