Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RegistrationService CLI] Remove deprecated --service option #22

Merged
merged 2 commits into from
Aug 9, 2022
Merged

[RegistrationService CLI] Remove deprecated --service option #22

merged 2 commits into from
Aug 9, 2022

Conversation

Izzzu
Copy link

@Izzzu Izzzu commented Aug 8, 2022 •
edited
Loading

What this PR changes/adds

Remove deprecated --service option

Why it does that

Clean up after adding -d option to Registration Service CLI

Linked Issue(s)

Linked to agera-edc/MinimumViableDataspace#43

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@github-actions
Copy link

github-actions bot commented Aug 8, 2022 •
edited
Loading

Unit Test Results

12 files  ±0  12 suites  ±0   5s ⏱️ +2s
38 tests  - 4  38 ✔️  - 4  0 💤 ±0  0 ❌ ±0 
46 runs   - 4  46 ✔️  - 4  0 💤 ±0  0 ❌ ±0 

Results for commit 7d4d5a2. ± Comparison against base commit 0b39c0b.

♻️ This comment has been updated with latest results.

@Izzzu Izzzu marked this pull request as ready for review August 8, 2022 16:03
@algattik
Copy link

algattik commented Aug 9, 2022

please remove the "closes" word so it doesn't auto-close the issue on downstream merge :)

@marcgs marcgs requested a review from ouphi August 9, 2022 08:42
algattik added a commit that referenced this pull request Aug 9, 2022
@algattik
Chore: ci full build (#22)
b945855 
* Update verify.yaml

* Update verify.yaml

* .
@Izzzu Izzzu merged commit ad36e4f into feature/43-clean-up Aug 9, 2022
@Izzzu Izzzu deleted the feature/43/43-clean-up branch August 9, 2022 12:07
cpeeyush pushed a commit that referenced this pull request Aug 12, 2022
@Izzzu
[Registration Service CLI] Remove deprecated --service option (#23)
b9ddac3 
* remove -s

* Revert "remove -s"

This reverts commit 0c5e40e.

* [RegistrationService CLI] Remove deprecated --service option (#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouphi ouphi ouphi approved these changes

@algattik algattik algattik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Izzzu @algattik @ouphi