Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/247/247 appinsights #23

Closed
wants to merge 4 commits into from
Closed

Feature/247/247 appinsights #23

wants to merge 4 commits into from

Conversation

algattik
Copy link

@algattik algattik commented Aug 9, 2022

What this PR changes/adds

Briefly describe WHAT your pr changes, which features it adds/modifies.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@github-actions
Copy link

github-actions bot commented Aug 9, 2022 •
edited
Loading

Unit Test Results

13 files  ±0  13 suites  ±0   8s ⏱️ -1s
53 tests ±0  53 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
65 runs  ±0  65 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 772bfe7. ± Comparison against base commit b945855.

♻️ This comment has been updated with latest results.

@algattik algattik closed this Aug 9, 2022
cpeeyush pushed a commit that referenced this pull request Aug 12, 2022
@Izzzu
[Registration Service CLI] Remove deprecated --service option (#23)
b9ddac3 
* remove -s

* Revert "remove -s"

This reverts commit 0c5e40e.

* [RegistrationService CLI] Remove deprecated --service option (#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@algattik