-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional tests, fix unset exit codes on panics #42
Add functional tests, fix unset exit codes on panics #42
Conversation
Bummer. Windows tests are failing with the same issue as #40 |
I believe we can fix the Windows issue with this: #40 (comment) |
I haven't been able to find time to get to review this. It's on my list, thank you for your patience! |
@agnivade Looks like We're all 🟢 now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanup comments. Looking great overall :)
Thanks for the reviews! |
I have a feeling this is going to remain flaky. I have restarted for now, but if this continues, we might want to skip the test in Windows. |
Thank you for the merge! Would you mind cutting a new release when you have a chance? That's fair. It looked to me like it wasn't always the same test that failed on Windows – I'm not certain though. It's possible too many tests were running in parallel, so we might consider |
Yeah, good point on the parallelism. I think we might be going a bit overboard on that. I am leaning towards simply removing |
Btw, I've cut a new release. |
I ran into a few panics in my projects and realized those triggered package failures but were "passing" the tests because they exited with 0.
This PR fixes those exit codes so it doesn't miss anything.
I had difficulty reproducing the failures for a while, which necessitated this new functional test style. I hope it is to your liking! 😄