Fix Windows CI test failures by cleaning env vars #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add script to clean the test environment variables. Uses a Go script for cross-OS portability.
JohnStarich
force-pushed
the
feature/cleanenv
branch
from
e1cdb6b
to
d4df943
Compare
JohnStarich
commented
Jan 29, 2023
internal/cmd/cleanenv/main.go
Outdated
| } | ||
| } | ||
|
|
||
| type App struct { |
There was a problem hiding this comment.
I designed this with extensibility and testability in mind, hence extra bits like this. It should help if we later decide to share the tool more widely.
agnivade
reviewed
Feb 2, 2023
There was a problem hiding this comment.
In my testing, I can see that:
cleanenv -remove-prefix=JAVA -- GOOS=js GOARCH=wasm go test -exec=/home/agniva/go/bin/wasmbrowsertest -v
fails with exec: "GOOS=js": executable file not found in $PATH, and we need to move the env var declarations ahead like so:
GOOS=js GOARCH=wasm cleanenv -remove-prefix=JAVA -- go test -exec=/home/agniva/go/bin/wasmbrowsertest -v
Wondering if we can look into supporting this? Or if it's too much work, we can just go ahead and document it.
JohnStarich
force-pushed
the
feature/cleanenv
branch
from
1c76b55
to
829cd5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script to clean the test environment variables.
Uses a Go script for easy cross-OS portability.
Currently underDone../internal/cmd/cleanenv. If it should be shared more widely, then./cmd/cleanenvmay be more appropriate.Fixes #40 and unblocks #42