docs: update main deploy README from main #2303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anant Sharma <anants@nvidia.com> Co-authored-by: Ishan Dhanani <idhanani@nvidia.com>
Co-authored-by: Dmitry Tokarev <dtokarev@nvidia.com>
Co-authored-by: Dmitry Tokarev <dtokarev@nvidia.com>
…link (#2239) Co-authored-by: Keiven Chang <keivenchang@users.noreply.github.com>
Signed-off-by: Anish <80174047+athreesh@users.noreply.github.com> Co-authored-by: Anish <80174047+athreesh@users.noreply.github.com>
atchernych
requested review from
a team,
ishandhanani,
nealvaidya,
nnshah1 and
whoisj
as code owners
atchernych
requested review from
GuanLuo,
PeaBrane,
alec-flowers,
biswapanda,
grahamking,
hhzhang16,
hutm,
jthomson04,
julienmancuso,
kkranen,
mohammedabdulwahhab,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4,
ryanolson,
tanmayv25,
tedzhouhk and
tmonty12
as code owners
Contributor
|
Warning Rate limit exceeded@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (81)
WalkthroughThis update extensively revises documentation, deployment guides, and configuration files across the project, especially for backend deployment patterns (vLLM, SGLang, TRTLLM) and Kubernetes integration. It introduces new deployment README files, restructures configuration YAMLs, updates Dockerfiles for dependency management, and removes or consolidates redundant documentation. Helm charts and operator logic are updated to replace a boolean Grove flag with a termination delay parameter and runtime Grove detection. Port allocation for vLLM is modularized into a new utility module. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Docs
participant K8s
participant Backend (vLLM/SGLang/TRTLLM)
participant Operator
participant ETCD
User->>Docs: Refer to deployment guide (README)
User->>K8s: Apply CR YAML (DynamoGraphDeployment)
K8s->>Operator: Notify of new CR
Operator->>K8s: Create Frontend/Worker Pods
Backend->>ETCD: Allocate/reserve ports (if needed)
User->>K8s: Port-forward to Frontend
User->>Backend: Send inference request via Frontend
Backend-->>User: Return inference result
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores