build: default to using dev instead of local-dev for vllm build #2837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-tusharma
requested review from
a team,
GuanLuo,
PeaBrane,
alec-flowers,
atchernych,
biswapanda,
grahamking,
hhzhang16,
hutm,
ishandhanani,
jasonqinzhou,
julienmancuso,
kkranen,
mohammedabdulwahhab,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4,
ryanolson,
tanmayv25,
tedzhouhk and
tmonty12
as code owners
nv-anants
approved these changes
Sep 3, 2025
Contributor
|
Caution Review failedFailed to post review comments. Configuration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (33)
💤 Files with no reviewable changes (3)
🧰 Additional context used🧠 Learnings (6)📓 Common learnings📚 Learning: 2025-07-18T16:04:31.771ZApplied to files:
📚 Learning: 2025-08-30T20:43:10.091ZApplied to files:
📚 Learning: 2025-08-30T20:43:49.632ZApplied to files:
📚 Learning: 2025-08-30T20:43:10.091ZApplied to files:
📚 Learning: 2025-09-03T01:10:12.599ZApplied to files:
🪛 LanguageTooldeploy/cloud/helm/platform/README.md[grammar] ~104-~104: There might be a mistake here. (QB_NEW_EN) docs/guides/dynamo_deploy/dynamo_operator.md[grammar] ~41-~41: There might be a mistake here. (QB_NEW_EN) docs/guides/dynamo_deploy/README.md[grammar] ~45-~45: There might be a mistake here. (QB_NEW_EN) [grammar] ~46-~46: There might be a mistake here. (QB_NEW_EN) [grammar] ~47-~47: There might be a mistake here. (QB_NEW_EN) [grammar] ~48-~48: There might be a mistake here. (QB_NEW_EN) [grammar] ~82-~82: There might be a mistake here. (QB_NEW_EN) [grammar] ~83-~83: There might be a mistake here. (QB_NEW_EN) docs/guides/dynamo_deploy/installation_guide.md[grammar] ~24-~24: There might be a mistake here. (QB_NEW_EN) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
WalkthroughRenamed local development image/target from local-dev to dev across devcontainer and build scripts. Updated Helm charts/docs, removed legacy deployment scripts/values, and revised installation guides/links. Bumped Helm versions. Added vLLM prefill integration guarded by can_prefill and improved error handling. Minor etcd image/config updates in platform values. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Handler as vLLM Handler
participant Prefill as Prefill Worker
participant Decoder as Decoder/Generator
Client->>Handler: generate(request, sampling_params)
alt can_prefill == 1
Note over Handler: Build single-token prefill params<br/>extra_args.kv_transfer_params.do_remote_decode=true
Handler->>Prefill: round_robin(prefill_request)
Prefill-->>Handler: prefill_response (kv_transfer_params)
Note over Handler: Merge kv_transfer_params into sampling_params.extra_args
else can_prefill == 0
Note over Handler: Skip prefill
end
Handler->>Decoder: generate(request, sampling_params)
Decoder-->>Handler: tokens/outputs
Handler-->>Client: MyRequestOutput
opt Errors
Note over Handler: Logs exceptions (including CancelledError)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
nv-tusharma
force-pushed
the
tusharma/cp-vllm-dev-alignment
branch
from
03f9a5d to
e9a96f0
Compare
This was referenced Sep 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Recent changes to Dockerfile.vllm resulted in the deletion of the dev stage in favor of local-dev stage. This was to align with the .devcontainer setup. However, to keep parity with other backends, the decision was made to keep the dev stage instead of local-dev. This PR updates the Dockerfile to use the dev stage as default instead of local-dev.
e432ae4
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Documentation
Chores