fix: update regex for namespace query in Grafana dashboard

[mohammedabdulwahhab]

Overview:

Update loki query so it can't default to all empty values

Summary by CodeRabbit

• New Features

  • None.

• Bug Fixes

  • Improved the Grafana Logging dashboard’s Namespace filter to disallow empty selections, ensuring queries exclude empty namespace values. This removes a misleading empty option in the dropdown and provides more reliable, consistent panel results.

• Chores

  • Configuration updated for the Namespace filter behavior in the logging dashboard.

[coderabbitai]

Walkthrough

Grafana dashboard configurations were updated to change the Namespace templating variable regex from an empty string to ".+", enforcing non-empty namespace selections. No other fields or public interfaces were modified.

Changes

Cohort / File(s)	Summary
Grafana namespace regex update deploy/logging/grafana/dashboard.json, deploy/logging/grafana/logging-dashboard.yaml	Updated templating variable for Namespace: regex from "" to ".+" to exclude empty values; all other settings unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The current PR description contains only a one-line Overview and does not follow the repository template: the Details, "Where should the reviewer start?", and Related Issues sections are missing, and it lacks concrete facts about which files changed, the exact regex change ("" → ".+"), rationale, and testing steps. Because these required template sections and actionable details are absent, the description is incomplete and insufficient for review.	Please update the PR description to match the template: add a Details section listing the modified files and the exact change (e.g., Namespace regex changed from "" to ".+"), a "Where should the reviewer start?" section pointing to deploy/logging/grafana/dashboard.json and logging-dashboard.yaml, include brief testing/verification steps and any impact notes, and add a Related Issues line referencing the issue number if applicable.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title is concise and accurately summarizes the primary change — updating the namespace regex used by the Grafana dashboard/Loki query — and is clear to a reviewer scanning history. It avoids unnecessary noise and directly reflects the main change in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Poem

I twitch my ears at logs that flow,
A dot and plus—now namespaces show.
No empties hop across the screen,
The dashboards gleam, precise and clean.
Thump-thump—Regex set just right,
A tidy warren in the night. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

deploy/logging/grafana/dashboard.json (2)

109-114: Prevent “All” from matching empty by setting an explicit allValue.

When “All” is selected, Grafana typically expands to .*, which still matches empty. To keep behavior consistent with your intent, set allValue to ".+".

Apply within the namespace variable block:

           "refresh": 1,
-          "regex": ".+",
+          "regex": ".+",
+          "allValue": ".+",
           "skipUrlSync": false,

---

109-114: Avoid drift between JSON and YAML dashboard sources.

Since this dashboard exists in both raw JSON and a YAML-embedded JSON, consider generating one from the other via your build/ops tooling to keep them in lockstep.

deploy/logging/grafana/logging-dashboard.yaml (2)

119-125: Set allValue to ".+" to align “All” with non-empty constraint.

Without this, “All” may expand to .* and include empty matches.

Patch inside the namespace variable block:

            "refresh": 1,
-            "regex": ".+",
+            "regex": ".+",
+            "allValue": ".+",
            "skipUrlSync": false,

---

1-221: Keep the JSON and ConfigMap-embedded JSON in sync automatically.

Recommend a single source of truth (e.g., maintain JSON only and template it into the ConfigMap at deploy time) to avoid inconsistencies.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dcee4db and 04a1b3e.

📒 Files selected for processing (2)

• deploy/logging/grafana/dashboard.json (1 hunks)
• deploy/logging/grafana/logging-dashboard.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build and Test - dynamo
• GitHub Check: Build and Test - sglang
• GitHub Check: Build and Test - vllm

🔇 Additional comments (2)

deploy/logging/grafana/dashboard.json (1)

109-114: LGTM: Non-empty namespace enforced in variable options.

Using ".+" filters out empty namespace label values from the picker. Matches PR intent.

deploy/logging/grafana/logging-dashboard.yaml (1)

119-125: LGTM: Mirrors JSON change to exclude empty namespaces.

"regex": ".+" on the namespace variable is correct here as well.