fix: dashboard fix

[mohammedabdulwahhab]

Overview:

Dashboard fixes:

• Reference grafana vars in query
• Need atleast one non-empty selector

Summary by CodeRabbit

• New Features
  • Added an “All” option to Namespace, Deployment, and Component selectors, enabling queries across all values.
  • Simplified log filtering: search and trace ID filters now use straightforward text matching for easier, faster queries.

[coderabbitai]

Walkthrough

This PR updates Loki query operators in two Grafana resources from case-insensitive regex (|~ "(?i)...") to substring match (|= "..."). It also adds allValue: ".+" to three dashboard template variables (Namespace, DynamoGraph Deployment, Component) to enable an All option pattern.

Changes

Cohort / File(s)	Summary
Loki query operator update deploy/logging/grafana/dashboard.json, deploy/logging/grafana/logging-dashboard.yaml	Replace case-insensitive regex filters `
Templating allValue additions deploy/logging/grafana/dashboard.json, deploy/logging/grafana/logging-dashboard.yaml	Add allValue: ".+" to templating variables: Namespace, DynamoGraph Deployment, and Component.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat: add reference setup for dynamo logging in k8s with loki #2699 — Changes the same Grafana dashboard with identical Loki operator updates and allValue additions.
• fix: update regex for namespace query in Grafana dashboard #3002 — Adjusts Grafana templating for Namespace to use ".+", overlapping with part of this PR’s templating changes.

Poem

A bunny taps the logs with care,
Swaps regex whiskers for substring flair.
“All” now hops across the fields,
.+ unlocks what filtering yields.
In dashboards green, I twitch my nose—
Trace and search, the signal shows.
Thump-thump: ship it, off it goes!

Pre-merge checks

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description contains a brief Overview noting "Reference grafana vars in query" and "Need atleast one non-empty selector" but does not follow the repository's required template: the Details, Where should the reviewer start?, and Related Issues sections are missing, leaving the description incomplete. Because required template sections are absent, the description fails to provide the necessary context for reviewers.	Please expand the PR description to follow the template: add a Details section describing the exact changes (e.g., deploy/logging/grafana/dashboard.json and deploy/logging/grafana/logging-dashboard.yaml, the change from
Title Check	❓ Inconclusive	The title "fix: dashboard fix" is related to the changeset because the PR updates Grafana dashboard queries and template variables, but it is overly generic and repetitive and does not communicate the primary change (e.g., switching Loki	~ regex filters to

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

deploy/logging/grafana/logging-dashboard.yaml (2)

69-69: Substring match is case-sensitive; confirm behavior change from previous case-insensitive regex.

Switching from |~ "(?i)$var" to |= "$var" drops regex capability and case-insensitive matching. If users expect case-insensitive search for $search/$trace_id, consider retaining |~ "(?i)${search:regex}"/|~ "(?i)${trace_id:regex}", or document the new behavior near the inputs.

---

128-128: Same as above: solid fix for “All” on deployment selector.

Consistency with namespace is good. Optional: align the variable’s "regex" filter to ".+" as well for symmetry with the Namespace var (UX nit).

deploy/logging/grafana/dashboard.json (2)

59-59: Substring match is case-sensitive; confirm behavior change from previous case-insensitive regex.

Changing to |= "$search" |= "$trace_id" removes regex and case-insensitive matching. If that’s unintended, revert to |~ "(?i)${search:regex}" |~ "(?i)${trace_id:regex}", or clearly indicate “case-sensitive substring” in the input labels.

---

118-118: Good: allValue: ".+" for Deployment.

Optional: align this variable’s "regex" field to ".+" like Namespace to keep UX consistent.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c382005 and 0ac9a92.

📒 Files selected for processing (2)

• deploy/logging/grafana/dashboard.json (4 hunks)
• deploy/logging/grafana/logging-dashboard.yaml (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and Test - dynamo

🔇 Additional comments (4)

deploy/logging/grafana/logging-dashboard.yaml (2)

103-103: Good: allValue: ".+" prevents empty/invalid matchers.

This ensures the label regex is non-empty when “All” is selected, satisfying Loki’s requirement for a non-empty selector. Verify that no label values can be empty; . + excludes empty strings.

---

153-153: Same as above: solid fix for “All” on component selector.

Prevents empty regex and keeps queries valid.

deploy/logging/grafana/dashboard.json (2)

93-93: Good: allValue: ".+" for Namespace avoids empty selector issues.

Matches the fix intent and keeps the stream selector valid even with “All.”

---

143-143: Good: allValue: ".+" for Component.

Prevents empty regex; keeps queries valid with “All.”