Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node interfaces in iron to avoid templated ComponentInterface #41

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Use node interfaces in iron to avoid templated ComponentInterface #41

merged 3 commits into from
Jul 18, 2023

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Jul 18, 2023

Description

Fast forward the three commits to the iron branch

Review guidelines

Estimated Time of Review: 1.1 minutes

@domire8
Refactor ComponentInterface to use node interfaces (#33)
86dd8c5 
* Move ComponentInterface constructor to source file

Remove template class NodeT

Change ComponentInterface constructor arguments to get all the node interfaces

* Pass the publisher type as argument to create_output

* Fix logging with logging interface

* Fix parameters with parameters interface

* Update creation of subscriptions, services and TF helpers

* Update ComponentInterface tests

* Rebase fixes

* 2.2.10 -> 2.2.11

* Update CHANGELOG
@domire8
Update component classes to inherit from new ComponentInterface (#38)
89cc2cb 
* Make qos private

* Fix creation of predicate publisher

* Update Component

* Update LifecycleComponent

* 2.2.11 -> 2.2.12

* Update CHANGELOG
@domire8
Revise ComponentInterface by moving implementations to source file (#39)
2f0133f 
* Fix docstring

* Move implementations from header to source file

* Clean up includes

* Touch ups

* 2.2.12 -> 2.2.13

* Update CHANGELOG
@domire8 domire8 requested a review from eeberhard July 18, 2023 06:00
@domire8 domire8 linked an issue Jul 18, 2023 that may be closed by this pull request
Use node interfaces in ros:iron to avoid templated ComponentInterface #32
Closed
@domire8 domire8 merged commit e0c66ff into iron Jul 18, 2023
3 of 5 checks passed
@domire8 domire8 deleted the iron-component-interface branch July 18, 2023 06:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eeberhard eeberhard Awaiting requested review from eeberhard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use node interfaces in ros:iron to avoid templated ComponentInterface
1 participant
@domire8