Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct how to refer to other required modules in the code #106

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Correct how to refer to other required modules in the code #106

merged 1 commit into from
Oct 4, 2024

Conversation

kimhanbeom
Copy link
Contributor

  • Changed REVIEW_PROTOCOL_VERSION to REQUIRED_MANAGER_VERSION.
  • Used REQUIRED_GIGANTO_VERSION instead of names that include INGEST or PUBLISH.

Close: #105

@kimhanbeom
Correct how to refer to other required modules in the code
99fdee5 
- Changed `REVIEW_PROTOCOL_VERSION` to `REQUIRED_MANAGER_VERSION`.
- Used `REQUIRED_GIGANTO_VERSION` instead of names that include `INGEST` or `PUBLISH`.

Close: #105
@kimhanbeom kimhanbeom requested a review from syncpark October 4, 2024 05:19
@kimhanbeom kimhanbeom self-assigned this Oct 4, 2024
@kimhanbeom kimhanbeom mentioned this pull request Oct 4, 2024
Merged
@kimhanbeom kimhanbeom merged commit bb6f136 into main Oct 4, 2024
8 checks passed
@kimhanbeom kimhanbeom deleted the david/modify-how-to-reference-other-required-modules branch October 4, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syncpark syncpark syncpark approved these changes

Assignees

@kimhanbeom kimhanbeom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct how to refer to other required modules in the code
2 participants
@kimhanbeom @syncpark