Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct how to refer to other required modules in the code #106

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).

### Changed

- Changed `REVIEW_PROTOCOL_VERSION` to "0.39.0"
- Correct how to refer to other required modules in the code.
- Changed `REVIEW_PROTOCOL_VERSION` to `REQUIRED_MANAGER_VERSION`.
- Used `REQUIRED_GIGANTO_VERSION` instead of names that include `INGEST` or `PUBLISH`.
- Changed `REQUIRED_MANAGER_VERSION` to "0.39.0"
- Updated review-protocol to version "0.7.0".
- As `get_config` was removed from `review-protocol::request::handler`,
Removed the `get_config` related code from the crusher.
Expand Down
4 changes: 2 additions & 2 deletions src/request.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use tracing::{error, info, trace, warn};

use crate::client::SERVER_RETRY_INTERVAL;

const REVIEW_PROTOCOL_VERSION: &str = "0.39.0";
const REQUIRED_MANAGER_VERSION: &str = "0.39.0";
const MAX_RETRIES: u8 = 3;

#[derive(Debug, Deserialize, Clone)]
Expand Down Expand Up @@ -166,7 +166,7 @@ async fn connect(
client.server_address,
env!("CARGO_PKG_NAME"),
env!("CARGO_PKG_VERSION"),
REVIEW_PROTOCOL_VERSION,
REQUIRED_MANAGER_VERSION,
&client.cert,
&client.key,
)?;
Expand Down
7 changes: 3 additions & 4 deletions src/subscribe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ use crate::{
request::{RequestedKind, RequestedPolicy},
};

const INGEST_PROTOCOL_VERSION: &str = "0.21.0";
const PUBLISH_PROTOCOL_VERSION: &str = "0.21.0";
const REQUIRED_GIGANTO_VERSION: &str = "0.21.0";
const TIME_SERIES_CHANNEL_SIZE: usize = 1;
const LAST_TIME_SERIES_TIMESTAMP_CHANNEL_SIZE: usize = 1;
const SECOND_TO_NANO: i64 = 1_000_000_000;
Expand Down Expand Up @@ -226,15 +225,15 @@ impl Client {
self.endpoint.clone(),
wait_shutdown.clone(),
self.last_series_time_path.clone(),
INGEST_PROTOCOL_VERSION,
REQUIRED_GIGANTO_VERSION,
),
publish_connection_control(
sender,
self.publish_addr,
&self.server_name,
&self.endpoint,
wait_shutdown.clone(),
PUBLISH_PROTOCOL_VERSION,
REQUIRED_GIGANTO_VERSION,
&self.request_recv,
active_policy_list,
delete_policy_ids,
Expand Down
Loading