Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Make sure we do not create DOM element when insertDefaultUI is false #4

Merged
merged 3 commits into from
Mar 16, 2017

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented Mar 14, 2017

In our app we have voice only chat with custom UI.

Publisher configuration:

{
  insertDefaultUI: false, 
  videoSource: null
}

Current build breaks due to exception thrown by OpenTok JS library when DOM element is provided to OTPublisher when insertDefaultUI = false.

Fixes issue #3

@aiham
Copy link
Contributor

aiham commented Mar 14, 2017

Hi @pronebird, thanks for contributing!

Do you mind editing your PR to point to the dev branch instead? That's where I've been doing my development actually. If you'd like to have a go at it, could you add some unit tests to test/OTPublisher.spec.js, probably in the with session prop suite? Otherwise I'll add the tests myself.

I should be adding a CONTRIBUTING.md file explaining all this later today.

@aiham aiham added the bug label Mar 15, 2017
@pronebird pronebird changed the base branch from master to dev March 15, 2017 10:09
@pronebird
Copy link
Contributor Author

pronebird commented Mar 15, 2017

@aiham I based my patch off dev branch and added test to make sure that container is not rendered when OTPublisher.properties is set to {insertDefaultUI: false}

Copy link
Contributor

@aiham aiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pronebird Thanks!

@aiham aiham merged commit a55595b into opentok:dev Mar 16, 2017
@pronebird pronebird deleted the fix/issue-3 branch March 16, 2017 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants