Remove AiiDA version defaults in Dockerfiles #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the AiiDA `core` version is obtained from the `build.json` these are just defaults that are rarely used. So at this point the default are only a source of confusion and over-specification.
csadorf
changed the title
danielhollas
added a commit
that referenced
this pull request
Nov 24, 2022
Also removed their default in Dockerfile, same fix as done in #311 for AIIDA_VERSION to reduce duplication.
danielhollas
added a commit
that referenced
this pull request
Nov 28, 2022
Also removed their default in Dockerfile, same fix as done in #311 for AIIDA_VERSION to reduce duplication.
unkcpz
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Move AIIDALAB_VERSION and AIIDALAB_HOME_VERSION to build.json Also removed their default in Dockerfile, same fix as done in #311 for AIIDA_VERSION to reduce duplication. * Bump aiidalab version to `22.11.0`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the AiiDA
coreversion is obtained from thebuild.json,these are just defaults that are rarely used. So at this point
the default are only a source of confusion and over-specification
and it is better to remove them.