Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python version in build.json #326

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Fix Python version in build.json #326

merged 3 commits into from
Nov 24, 2022

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Nov 23, 2022

This was an omission in #318. The Python version specified in build.json is used to automatically generate the image tags on Dockerhub. So currently, for example the image aiidalab/full-stack:python-9.4 actually corresponds to python-9.13

https://hub.docker.com/r/aiidalab/full-stack/tags

image

In short, when updating the Python version, we need to update both the stack/base/Dockerfile and build.json

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @danielhollas Last change #318 as you said is an omission.

I think the default BASE in stack/base/Dockerfile is set in docker-bake.hcl for build the image. Remove the ARG BASE=jupyter/minimal-notebook:python-3.9.13 should be fine and good to have only one place to set the version.

@unkcpz
Copy link
Member

unkcpz commented Nov 24, 2022

If seems the variable can not pass directly to FROM, but need to ARG first, https://stackoverflow.com/questions/36556766/can-a-variable-be-used-in-docker-from this may help.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! Thanks!

@unkcpz unkcpz merged commit 4556c62 into main Nov 24, 2022
@unkcpz unkcpz deleted the fix-python-version branch November 24, 2022 14:01
@danielhollas
Copy link
Contributor Author

@unkcpz thanks! I just confirmed that the images published before this PR were still on Python 9.4, so the PR in #318 didn't work.
The fix with ARG BASE was the same as what Marnik did in #311 for AIIDA_VERSION.

I'll open a new PR where I will do the same fix for AIIDALAB_VERSION and AIIDALAB_HOME_VERSION in stack/lab/Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants