Fix pip check test
#489
Merged
Fix pip check test
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
unpin-action-release
branch
from
c62838d to
e60ec99
Compare
danielhollas
force-pushed
the
unpin-action-release
branch
from
e60ec99 to
ca99554
Compare
danielhollas
commented
Aug 6, 2024
| mamba install --yes \ | ||
| aiida-core==${AIIDA_VERSION} \ | ||
| mamba-bash-completion \ | ||
| && mamba clean --all -f -y && \ | ||
| fix-permissions "${CONDA_DIR}" && \ | ||
| fix-permissions "/home/${NB_USER}" |
There was a problem hiding this comment.
This command should not be touching home folder at all so we can simply remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #490. The offending packages have been fixed upstream, but we need to forcibly update
async_generatorandcertipyto pick up those changes since these are already part of the jupyter base image.Additionally, I've unpinned the
softprops/actions-gh-releaseaction.Pinning this action to specific patch version just creates noise from dependabot. Given that we currently don't pin any other actions to the exact versions, let's unpin this one as well.
Closes #487