Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip check test #489

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fix pip check test #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8df088
Unpin softprops/action-gh-release
danielhollas Aug 2, 2024
ca99554
Update packages to satisfy pip check
danielhollas Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:
needs: [publish-dockerhub]

steps:
- uses: softprops/action-gh-release@v2.0.6
- uses: softprops/action-gh-release@v2
name: Create release
with:
generate_release_notes: true
7 changes: 4 additions & 3 deletions stack/base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,15 @@ ENV PIP_CONSTRAINT /opt/requirements.txt
COPY pip.conf /etc/pip.conf

# Upgrade pip and mamba to latest
# Update async_generator, certipy to satisfy `pip check`
# https://github.com/aiidalab/aiidalab-docker-stack/issues/490
# Install aiida-core and other shared requirements.
RUN mamba update -y pip && \
RUN mamba update -y pip async_generator certipy && \
mamba install --yes \
aiida-core==${AIIDA_VERSION} \
mamba-bash-completion \
&& mamba clean --all -f -y && \
fix-permissions "${CONDA_DIR}" && \
fix-permissions "/home/${NB_USER}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command should not be touching home folder at all so we can simply remove this.

fix-permissions "${CONDA_DIR}"

# Enable verdi autocompletion.
RUN mkdir -p "${CONDA_DIR}/etc/conda/activate.d" && \
Expand Down