Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to clean up the scratch #815

Closed
superstar54 opened this issue Sep 26, 2024 · 0 comments · Fixed by #838
Closed

Add button to clean up the scratch #815

superstar54 opened this issue Sep 26, 2024 · 0 comments · Fixed by #838
Assignees
@mikibonacci
Labels
enhancement New feature or request

Comments

@superstar54
Copy link
Member

When the job is killed (or in general when it’s finished), show button to clean up the scratch
@superstar54 superstar54 added the enhancement New feature or request label Sep 26, 2024
@mikibonacci mikibonacci mentioned this issue Oct 3, 2024
Merged
mikibonacci added a commit that referenced this issue Oct 4, 2024
@mikibonacci @AndresOrtegaGuerrero
Feature/clean button (#838)
73f2534 
This fixes #815

* Clean button added

also, modified a bit the logic of kill button (hidden by default,
as sometimes it is loaded - seen for a second - but not necessary)

* Added minimal test for kill and clean button diplay.

* Fixed hiding of the kill workchain button when process is_terminated

* Changing a line, better implementation

* Replacing double bool check with only one.

---------

Co-authored-by: AndresOrtegaGuerrero <34098967+AndresOrtegaGuerrero@users.noreply.github.com>
@mikibonacci mikibonacci mentioned this issue Oct 10, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikibonacci mikibonacci

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/clean button mikibonacci/aiidalab-qe
2 participants
@superstar54 @mikibonacci