Feature/clean button #838
Merged
Feature/clean button #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, modified a bit the logic of kill button (hidden by default, as sometimes it is loaded - seen for a second - but not necessary)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
- Coverage 67.95% 67.84% -0.12%
==========================================
Files 50 50
Lines 4475 4503 +28
==========================================
+ Hits 3041 3055 +14
- Misses 1434 1448 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| def _update_clean_scratch_button_layout(self): | ||
| """Update the layout of the kill button.""" | ||
| # The button is hidden by default, but if we load a new process, we hide again. | ||
| if self.process is None or self.process == "": |
There was a problem hiding this comment.
if not self.process:
| ) | ||
| except (OSError, KeyError): | ||
| pass | ||
| self.clean_scratch_button.disabled = False not in cleaned_bool |
There was a problem hiding this comment.
not any(clean_bool)
Does this one work ?
There was a problem hiding this comment.
yes, I implemented self...disabled=all(cleaned_bool)
AndresOrtegaGuerrero
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #815
For now, the
clean remote databutton is always shown for a finished workchain; if the remote folders are empty, the button is still there but is disabled. I am not sure if we should always display it, and that the name of the button is the best suited one.waiting for some comments @AndresOrtegaGuerrero , @superstar54