PhCalculation: Fix bug when only_initialization=True
#813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/811/phcalculation-only-initialization
branch
from
b92b00d
to
ef76d76
Compare
In that case I maybe better add a test to ensure the current functionality is preserved. |
When the `only_initialization` setting is set to `True` the plugin would add an instruction to the `remote_copy_list` to copy `DYN_MAT` folder from the `parent_folder`. However, this would fail if the `parent_folder` was that of a `PwCalculation`, which is one of the main use cases of the `PhCalculation`. It is not entirely clear why this was added in the commit that added it dfdca7e which was just adding a plugin for EPW. We assume it was added by mistake and so remove it. A test is added for the `only_initialization=True` case since that didn't exist yet. Unfortunately, this test won't prevent the same bug being introduced because the incorrect code isn't triggered until the engine tries to execute the copy commands. This is not possible to reproduce in this simple unit test.
sphuber
force-pushed
the
fix/811/phcalculation-only-initialization
branch
from
ef76d76
to
0fe6f3d
Compare
|
@mbercx I added a test but realized that it won't actually prevent the same bug from being introduced in the future because it won't materialize until the engine tries to actually execute the file copy instructions. Still, thought this additional test is better than nothing. Don't feel like adding an integration test for this though. |
mbercx
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #811
When the
only_initializationsetting is set toTruethe plugin wouldadd an instruction to the
remote_copy_listto copyDYN_MATfolderfrom the
parent_folder. However, this would fail if theparent_folderwas that of a
PwCalculation, which is one of the main use cases of thePhCalculation.It is not entirely clear why this was added in the commit that added it
dfdca7e which was just adding a plugin
for EPW. We assume it was added by mistake and so remove it.