Commits on Jun 2, 2022

1. PhCalculation: Fix bug when only_initialization=True …

   When the `only_initialization` setting is set to `True` the plugin would
   add an instruction to the `remote_copy_list` to copy `DYN_MAT` folder
   from the `parent_folder`. However, this would fail if the `parent_folder`
   was that of a `PwCalculation`, which is one of the main use cases of the
   `PhCalculation`.
   
   It is not entirely clear why this was added in the commit that added it
   dfdca7e which was just adding a plugin
   for EPW. We assume it was added by mistake and so remove it.
   
   A test is added for the `only_initialization=True` case since that
   didn't exist yet. Unfortunately, this test won't prevent the same bug
   being introduced because the incorrect code isn't triggered until the
   engine tries to execute the copy commands. This is not possible to
   reproduce in this simple unit test.

   

   sphuber committed Jun 2, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 0fe6f3d
   • Browse repository at this point

   Copy the full SHA

   0fe6f3d View commit details

   Browse the repository at this point in the history