-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the concept of an object-store UUID to identify it #11
Comments
Also:
|
@sphuber do we want this in AiiDA, so we know we are pointing to the right container? A bit like the UUID for RabbitMQ, or the same for the DB (I don't know if we have one implemented yet). Also, should it be generated automatically when creating the container, or should it be settable by the user? |
I don't think it is necessary. We don't have it now, after all, currently we also just have an absolute filepath in the profile pointing to the database. However, it might actually be a useful feature, and will allow us to perform some sanity checks. If we implement this, I would definitely lean to not allowing a user to determine the UUID, we just generate one. For the interface in the |
This fixes aiidateam#11 I also fixed a bug I discovered, where config values that were cached but the cache was not cleared when re-initialising the container. To reduce the risk of such a problem, I am now only caching the *whole* configuration dictionary (and not each value), and I don't need to implement caching anymore for each single config value; and I just need to clear one variable `self._config` rather than each newly-defined configuration. In addition, I add a test to check that re-initialising the container creates a new container ID (`container.container_id`).
This fixes aiidateam#11 I also fixed a bug I discovered, where config values that were cached but the cache was not cleared when re-initialising the container. To reduce the risk of such a problem, I am now only caching the *whole* configuration dictionary (and not each value), and I don't need to implement caching anymore for each single config value; and I just need to clear one variable `self._config` rather than each newly-defined configuration. In addition, I add a test to check that re-initialising the container creates a new container ID (`container.container_id`).
E.g. to associate it with an existing DB, or to uniquely refer to it.
This could be generated during the
init_container
call and then stored in the repository config jsonThe text was updated successfully, but these errors were encountered: