✨ Add the concept of a (unique) container ID #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes aiidateam#11 I also fixed a bug I discovered, where config values that were cached but the cache was not cleared when re-initialising the container. To reduce the risk of such a problem, I am now only caching the *whole* configuration dictionary (and not each value), and I don't need to implement caching anymore for each single config value; and I just need to clear one variable `self._config` rather than each newly-defined configuration. In addition, I add a test to check that re-initialising the container creates a new container ID (`container.container_id`).
giovannipizzi
force-pushed
the
fix_11_repo_id
branch
from
c69da7a to
a121bec
Compare
Codecov Report
@@ Coverage Diff @@
## develop #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1502 1502
=========================================
Hits 1502 1502
Continue to review full report at Codecov.
|
chrisjsewell
approved these changes
Oct 2, 2020
chrisjsewell
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11
I also fixed a bug I discovered, where config values that
were cached but the cache was not cleared when re-initialising the
container.
To reduce the risk of such a problem, I am now only caching the whole
configuration dictionary (and not each value), and I don't need to
implement caching anymore for each single config value; and I just
need to clear one variable
self._configrather than each newly-definedconfiguration.
In addition, I add a test to check that re-initialising the container
creates a new container ID (
container.container_id).