Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Fix Python 3.8 warnings #666

Merged
merged 10 commits into from
Nov 22, 2019
Merged

Fix Python 3.8 warnings #666

merged 10 commits into from
Nov 22, 2019

Conversation

popravich
Copy link
Contributor

@popravich popravich commented Nov 19, 2019

What do these changes do?

Remove loop argument.

Are there changes in behavior for the user?

Nope

Related issue number

#648

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example:
      Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #666 into master will decrease coverage by 0.01%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   97.07%   97.06%   -0.02%     
==========================================
  Files          57       57              
  Lines        8493     8111     -382     
  Branches      573      568       -5     
==========================================
- Hits         8245     7873     -372     
+ Misses        176      172       -4     
+ Partials       72       66       -6
Impacted Files Coverage Δ
tests/geo_commands_test.py 100% <ø> (ø) ⬆️
tests/set_commands_test.py 100% <ø> (ø) ⬆️
tests/multi_exec_test.py 94.28% <ø> (-5.72%) ⬇️
tests/hyperloglog_commands_test.py 100% <ø> (ø) ⬆️
tests/sorted_set_commands_test.py 100% <ø> (ø) ⬆️
tests/stream_test.py 100% <ø> (ø) ⬆️
tests/pubsub_commands_test.py 100% <100%> (ø) ⬆️
tests/pool_test.py 99.7% <100%> (-0.03%) ⬇️
tests/task_cancellation_test.py 100% <100%> (ø) ⬆️
tests/stream_commands_test.py 100% <100%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b823e...2085f4b. Read the comment docs.

@popravich popravich merged commit 80abe42 into master Nov 22, 2019
@popravich popravich deleted the python38 branch November 22, 2019 08:12
wmorrell added a commit to wmorrell/channels_redis that referenced this pull request May 27, 2020
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
wmorrell added a commit to wmorrell/channels_redis that referenced this pull request Jun 15, 2020
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
carltongibson pushed a commit to django/channels_redis that referenced this pull request Jun 25, 2020
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and #179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
dudleyhunt86 added a commit to dudleyhunt86/channels_redis-python-dev that referenced this pull request Oct 7, 2022
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django/channels_redis#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant